This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix crash adding mixture of points and shapes #5097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
force-pushed
the
1ec5-add-annotations-mixture-5096
branch
from
b2964e1
to
645dd25
Compare
friedbunny
added a commit
that referenced
this pull request
May 25, 2016
#5097 introduced different arrays for points and shapes, but only ever attempted to use the points array. Adding a shape would crash.
friedbunny
added a commit
that referenced
this pull request
May 25, 2016
#5097 introduced different arrays for points and shapes, but only ever attempted to use the points array. Adding a shape would crash.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5096. No blurb has been added to the iOS SDK changelog because the regression was introduced in #4766, which has not yet been released.
/cc @boundsj